pkg/ansible/controller: Updater api reader to use client #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
added
kind/bug
openshift-ci-robot
added
needs-rebase
openshift-ci-robot
added
size/S
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
0f8245c to
ef61bba
Compare
openshift-ci-robot
added
size/M
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
a688bc2 to
084b0a2
Compare
shawn-hurley
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
fabianvf
reviewed
Feb 4, 2019
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
084b0a2 to
13cc9b5
Compare
* Handle case when CR is changed while we are working on it. To handle this we will return and just re-run the reconcile this should be fine due to eventually consistent model.
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
13cc9b5 to
1e0a343
Compare
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
…mework#1054) * Handle case when CR is changed while we are working on it. To handle this we will return and just re-run the reconcile this should be fine due to eventually consistent model.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Use the API reader to get the object from API after ansible has run.
Also, to deal with changes that a user could have made during the reconciliation run, we will just requeue the object and handle. This conforms to the eventually consistent model.
Motivation for the change:
To change the case when a resource is updated by the user as we are reconciling. This means that we will stop what we are doing and requeue the update.