-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
cmd/operator-sdk/new: make git init opt-in with --git-init flag #1588
cmd/operator-sdk/new: make git init opt-in with --git-init flag #1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we did a poll on slack and we said lets skip git init altogether? And make it opt in instead. If my memory serves me right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold After further discussion, we're going to make |
4af5af6
to
31c242c
Compare
@joelanford @lilic PTAL again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments but overall lgtm
We should update the migration guide as well, that's the only other place I found this flag mentioned -> https://github.com/operator-framework/operator-sdk/blob/2ad2ee217424fcfde9bb4cfba00d845f988ec511/doc/migration/v0.1.0-migration-guide.md#create-a-new-v010-project
@lilic That migration guide is for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, otherwise
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Changed the flag
--skip-git-init
to--git-init
to makegit init
opt-in instead of opt-out.Also
operator-sdk new
will no longer create the initial commit.Motivation for the change:
Creating the initial commit is unexpected behavior and can fail certain scenarios as described in #1198 .
Havinggit init
as opt-out via--skip-git-init
instead of opt-in is debatable, and so is unchanged at the moment.I am leaning towards makinggit init
opt-in but can address that in a follow up PR after we discuss it on the issue.Changed
git init
to opt-in per the consensus from the community and maintainers.Closes: #1198