Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pkg/helm/controller/reconcile.go: print manifest diffs at info level #1857

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

joelanford
Copy link
Member

Description of the change:
In the helm-operator, print the manifest diffs only if the info log level is enabled.

Motivation for the change:
Closes #1855

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2019
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@joelanford joelanford merged commit 0923815 into operator-framework:master Aug 26, 2019
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Aug 26, 2019
joelanford added a commit that referenced this pull request Aug 27, 2019
* version,cmd/operator-sdk/version: add go version, os, and arch to version subcommand

* CHANGELOG.md: added lines for #1857 and #1863, removed dup for #1277
@joelanford joelanford deleted the helm-log-manifest branch August 27, 2019 17:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent helm/kubernetes manifests in logfiles for helm-operator
3 participants