-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ansible images using just ubi8 #2004
ansible images using just ubi8 #2004
Conversation
Hi @joelanford, JFY. Not passing because of the usage of inotify. I am adding it with the download of the image and trying to check. It is just used here:
|
/test e2e-aws-helm |
/test e2e-aws-subcommand |
/test e2e-aws-ansible |
# Install inotify-tools. Note: rpm -i will install the rpm in the registry for allow the yum install it. | ||
&& curl -O https://rpmfind.net/linux/fedora/linux/releases/30/Everything/x86_64/os/Packages/i/inotify-tools-3.14-16.fc30.x86_64.rpm \ | ||
&& rpm -i inotify-tools-3.14-16.fc30.x86_64.rpm \ | ||
&& yum install inotify-tools \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use yum install -y
directly on the RPM url:
&& yum install -y https://rpmfind.net/linux/fedora/linux/releases/30/Everything/x86_64/os/Packages/i/inotify-tools-3.14-16.fc30.x86_64.rpm \
&& curl -O https://rpmfind.net/linux/fedora/linux/releases/30/Everything/x86_64/os/Packages/i/inotify-tools-3.14-16.fc30.x86_64.rpm \ | ||
&& rpm -i inotify-tools-3.14-16.fc30.x86_64.rpm \ | ||
&& yum install inotify-tools \ | ||
&& pip3 install --upgrade setuptools pip \ | ||
&& pip install --no-cache-dir --ignore-installed ipaddress \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 Is there some reason we're using pip
in line 34 but pip3
in line 33? If so, a comment explaining why would be good, since I would think we would use pip3
across the board after upgrading to python 3.
/cc @fabianvf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required to install setuptools which is not satisfied with pip3
Maybe it can work with python3-setuptools. I will try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked and I remember what happened. Previously, I faced an issue in the setup.py script to install ansible using pip3, however, it worked locally now. Probably it was because it was missing some of the upgrades made so far.
/test e2e-aws-go |
Hi @joelanford, I think it is OK to go now. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when CI passes.
Would like a review from @fabianvf before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Ansible images using just ubi8
Motivation for the change:
#1656