Add blacklist option to Ansible watches.yaml #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
asmacdo
added
language/ansible
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
f5dc386 to
2734d23
Compare
openshift-ci-robot
added
the
size/L
pkg/ansible/proxy/cache_response.go
Outdated
| ownerGV, err := schema.ParseGroupVersion(owner.APIVersion) | ||
| if err != nil { | ||
| // TODO(asmacdo) what circumstances cause this path? | ||
| log.Error(err, "Could not get owner reference from proxy.") |
There was a problem hiding this comment.
Suggested change
| log.Error(err, "Could not get owner reference from proxy.") | |
| log.Error(err, "Unable to parse Group Version") |
There was a problem hiding this comment.
I am not sure if I got this one.
So, the idea is watch all - some specific GVK?
If yes, would not work just add an if here and not add the GVK in the map if it is in the blacklist?
|
@camilamacedo86, I originally planned to do what you suggested, but the blacklisted watches would be created anyway by the proxy as a side effect of owner reference injection and caching. |
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
e5b561e to
37d28fc
Compare
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
6 times, most recently
from
d5db444 to
88538a7
Compare
asmacdo
removed
the
do-not-merge/work-in-progress
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
88538a7 to
7476a3b
Compare
openshift-ci-robot
added
the
needs-rebase
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
7476a3b to
54098dd
Compare
openshift-ci-robot
removed
the
needs-rebase
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
54098dd to
e44929c
Compare
fabianvf
reviewed
Jan 21, 2020
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
3 times, most recently
from
58ce455 to
6457169
Compare
joelanford
reviewed
Jan 22, 2020
With the addition of this feature, users will be able to prevent the creation of watches for secondary resources by specifying a blacklist of GVKs. The CI was flakey due to the timeouts, so they were bumped as well. Performance test: try to bail early
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
6457169 to
9390ee5
Compare
asmacdo
force-pushed
the
605-blacklist-ansible-watches
branch
from
3e741d4 to
698a3ba
Compare
|
/lgtm |
fabianvf
approved these changes
Jan 24, 2020
jmrodri
approved these changes
Jan 24, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of this feature, users will be able to prevent the
creation of watches for secondary resources by specifying a blacklist
of GVKs.
The CI was flakey due to the timeouts, so they were bumped as well.