Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cmd/operator-sdk: run and cleanup commands #2441

Merged
merged 13 commits into from
Jan 21, 2020
Merged

cmd/operator-sdk: run and cleanup commands #2441

merged 13 commits into from
Jan 21, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jan 20, 2020 •
edited
Loading

Description of the change:

  • cmd/operator-sdk: run local is now run --local, alpha run --olm is now run --olm, and alpha cleanup --olm is now cleanup --olm.
  • doc/cli: regenerate cli

Motivation for the change: unconnected commands were doing similar things, so they should be unified under one command.

@estroz estroz added refactoring olm-integration Issue relates to the OLM integration labels Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2020
@estroz estroz changed the title cmd/operator-sdk: unify run-like commands under run command cmd/operator-sdk: unify run-like/cleanup-like commands under run/cleanup Jan 20, 2020
joelanford
joelanford approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing comments.

@estroz estroz changed the title cmd/operator-sdk: unify run-like/cleanup-like commands under run/cleanup cmd/operator-sdk: run and cleanup commands Jan 21, 2020
@estroz estroz merged commit b24e4d3 into operator-framework:master Jan 21, 2020
@estroz estroz deleted the refactor/run-cli branch January 21, 2020 21:38
This was referenced Jan 22, 2020
Merged
Merged
@benoit-a benoit-a mentioned this pull request Jan 28, 2020
Closed
@camilamacedo86 camilamacedo86 mentioned this pull request Mar 3, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
olm-integration Issue relates to the OLM integration size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estroz @joelanford @openshift-ci-robot