Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cmd/operator-sdk/generate/packagemanifests: add --from-version flag #3509

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 23, 2020

Description of the change: add generate packagemanifests --from-version.

Motivation for the change: I'm not sure why this wasn't included in the original command, since it is still required to populate a CSV's spec.replaces.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz estroz force-pushed the bugfix/from-version branch from 5ee9c0e to 34568f1 Compare July 23, 2020 23:42
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Is this flag available in v0.19.0? If not, we should backport this.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm +1 to backport it.

@estroz estroz merged commit d63151b into operator-framework:master Jul 24, 2020
@estroz estroz deleted the bugfix/from-version branch July 24, 2020 15:36
estroz pushed a commit to estroz/operator-sdk that referenced this pull request Jul 24, 2020
estroz pushed a commit that referenced this pull request Jul 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants