Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cleanup: helm gitignore #3810

Merged
merged 1 commit into from
Aug 29, 2020
Merged

cleanup: helm gitignore #3810

merged 1 commit into from
Aug 29, 2020

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Aug 28, 2020

Description of the change:

  • For Helm-based Operators, cleanup the file .gitignore in order to not have invalid instructions for the type.

Motivation for the change:

  • keep standard across the project
  • helm operator has no go files and should not have its instructions in the gitignore as well.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@camilamacedo86 camilamacedo86 merged commit ab52c5c into operator-framework:master Aug 29, 2020
@camilamacedo86 camilamacedo86 deleted the helm-gitiginore-clean branch August 29, 2020 09:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants