for helm/ansible fix msg for multigroup support #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
requested review from
bharathi-tenneti,
theishshah and
varshaprasad96
and removed request for
estroz
camilamacedo86
added
kind/feature
camilamacedo86
changed the title
|
Hi @joelanford, The problem is solved as suggested. By justing changing the msg. Feel free to check. |
joelanford
previously requested changes
Sep 14, 2020
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
changed the title
estroz
suggested changes
Sep 14, 2020
| @@ -88,8 +87,7 @@ func (s *apiScaffolder) scaffold() error { | |||
|
|
|||
| // Check that the provided group can be added to the project | |||
| if !s.config.MultiGroup && len(s.config.Resources) != 0 && !s.config.HasGroup(resourceOptions.Group) { | |||
| return fmt.Errorf("multiple groups are not allowed by default, to enable multi-group visit %s", | |||
| "kubebuilder.io/migration/multi-group.html") | |||
| return errors.New("support for multiple groups is disabled; to enable, set `multigroup: true` in the PROJECT file") | |||
There was a problem hiding this comment.
For consistency with the Go error:
Suggested change
| return errors.New("support for multiple groups is disabled; to enable, set `multigroup: true` in the PROJECT file") | |
| return errors.New("multiple groups are not allowed by default, to enable multi-group set 'multigroup: true' in your PROJECT file") |
camilamacedo86
dismissed
joelanford’s stale review
@joe i am moving forward with since all your changes were suggested and it is very tiny/small
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Ansible/Helm fix mensagem for multigroup support
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs