-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
internal/olm/operator: fix operator-registry image for run packagemanifests #3856
internal/olm/operator: fix operator-registry image for run packagemanifests #3856
Conversation
bd7a825
to
1880840
Compare
) | ||
|
||
const ( | ||
// The image operator-registry's initializer and registry-server binaries | ||
// are run from. | ||
// QUESTION(estroz): version registry image? | ||
registryBaseImage = "quay.io/openshift/origin-operator-registry:latest" | ||
registryBaseImage = "quay.io/operator-framework/upstream-registry-builder:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw
Waiting for Deployment \\\"default/e2e-fkkv-registry-server\\\" to rollout: 0 of 1 updated replicas are available\"\ntime=\"2020-09-04T15:34:20Z\" level=fatal msg=\"Failed to run packagemanifests: create catalog: error creating registry resources: error registering package: error waiting for Deployment \\\"default/e2e-fkkv-registry-server\\\" to roll out: timed out waiting for the condition\\n\"\n",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit
otherwise, /lgtm
1880840
to
859aef4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
the nit is not a blocker at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@joelanford we have the test/integration using mock static data. It might be the case of the issue: https://travis-ci.org/github/operator-framework/operator-sdk/jobs/724251712#L1731 |
New changes are detected. LGTM label has been removed. |
98c39e1
to
958c0c9
Compare
21c6141
to
c34a635
Compare
c34a635
to
4f8cf1b
Compare
@joelanford Have this been tested on OCP (Openshift)? When I try out your fork, I am hitting a panic when it tries to run
When I debug the pod (oc debug) and found that I get permission denied with touch which I assume the SQL package will also hit this (unable to open database file coming from SQL package)
When I run it as root, I face no issues. I assume the permission for
|
@Doout this will need a follow-up to support all cluster types. Can you make an issue with the information in your comment above? |
…ifests (operator-framework#3856) * internal/olm/operator: fix operator-registry image for run packagemanifests * internal/olm/client/client.go: return error for failed CSV * use switch for DoCSVWait phase logic * pin to olm 0.15.1 for integration tests
…ifests (operator-framework#3856) * internal/olm/operator: fix operator-registry image for run packagemanifests * internal/olm/client/client.go: return error for failed CSV * use switch for DoCSVWait phase logic * pin to olm 0.15.1 for integration tests
…ifests (operator-framework#3856) * internal/olm/operator: fix operator-registry image for run packagemanifests * internal/olm/client/client.go: return error for failed CSV * use switch for DoCSVWait phase logic * pin to olm 0.15.1 for integration tests
Description of the change:
Fixed a bug with
run packagemanifests
that caused the underlying registry pod to fail to start. Changed the registry pod image fromquay.io/openshift/origin-operator-registry:latest
toquay.io/operator-framework/upstream-registry-builder:latest
Motivation for the change:
The
run packagemanifests
command is broken and needs to be fixed.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs