[olm] Improve error message in olm install cmd #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/olm/installer/client.go
Outdated
| @@ -183,7 +183,7 @@ func (c Client) getResources(ctx context.Context, version string) ([]unstructure | |||
| } | |||
There was a problem hiding this comment.
just missing fragment
camilamacedo86
approved these changes
Sep 17, 2020
estroz
reviewed
Sep 17, 2020
varshaprasad96
force-pushed
the
olm/improve-logs
branch
from
80eea02 to
5eddcee
Compare
varshaprasad96
force-pushed
the
olm/improve-logs
branch
2 times, most recently
from
896b176 to
953adb9
Compare
varshaprasad96
force-pushed
the
olm/improve-logs
branch
from
953adb9 to
702760e
Compare
Notify user when olm tag is present in github but manifests cannot be located while installing olm.
varshaprasad96
force-pushed
the
olm/improve-logs
branch
from
702760e to
f234639
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Notify user when olm tag is present in github but manifests cannot be located
while installing olm.
Motivation for the change:
Provide better info to users when olm installation fails.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs