Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates to the tutorial docs #4395

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Jan 13, 2021

Description of the change:
While using the operator-sdk docs, I encountered the following issues:

[...]
Failure [0.005 seconds]
[BeforeSuite] BeforeSuite 
/home/marty/projects/memcached-operator/controllers/suite_test.go:52

  Unexpected error:
      <*fmt.wrapError | 0xc0003d0ac0>: {
          msg: "failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory",
          err: {
              Op: "fork/exec",
              Path: "/usr/local/kubebuilder/bin/etcd",
              Err: 0x2,
          },
      }
      failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory
  occurred

  /home/marty/projects/memcached-operator/controllers/suite_test.go:62

Installing kubebuilder fixes the issue. Ref: Issue #4203.

kubectl get deployment command should not display memcached-operator-controller-manager as it is not in the default namespace

Motivation for the change:
Improve the docs.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@hickeyma hickeyma force-pushed the fix/tutorial-issues branch from 5f65168 to c5c4e66 Compare January 15, 2021 16:28
@hickeyma
Copy link
Contributor Author

Thanks for the review and comments @estroz. I replied inline to your feedback.

@hickeyma hickeyma force-pushed the fix/tutorial-issues branch from c5c4e66 to 1944761 Compare January 18, 2021 14:42
@hickeyma
Copy link
Contributor Author

Updates and feedback provided inline. Thanks for review @camilamacedo86 @estroz.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@hickeyma
Copy link
Contributor Author

@camilamacedo86 @estroz Found the issue with the test suite and responded in #4395 (comment). Just wondering if a note should be added until a fix becomes available?

@hickeyma hickeyma force-pushed the fix/tutorial-issues branch from 1944761 to 7023f45 Compare January 20, 2021 16:43
Fix issues in the operaor-sdk docs..

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma hickeyma force-pushed the fix/tutorial-issues branch from 7023f45 to eca3e3d Compare January 20, 2021 17:05
@hickeyma
Copy link
Contributor Author

Updated following latest review comments from @estroz. It is good for review again @camilamacedo86 @estroz.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@estroz estroz merged commit 160cd9f into operator-framework:master Jan 20, 2021
@hickeyma hickeyma deleted the fix/tutorial-issues branch January 20, 2021 17:18
@hickeyma
Copy link
Contributor Author

Thanks for the reviews @camilamacedo86 and @estroz and the merge @estroz.

@estroz
Copy link
Member

estroz commented Jan 20, 2021

@hickeyma thanks a ton for the contribution!

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Jan 23, 2021
Fix issues in the operaor-sdk docs..

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
Fix issues in the operaor-sdk docs..

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
Fix issues in the operaor-sdk docs..

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
Fix issues in the operaor-sdk docs..

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this pull request Feb 5, 2021
Fix issues in the operaor-sdk docs..

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>Signed-off-by: rearl <rearl@secureworks.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants