-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updates to the tutorial docs #4395
Updates to the tutorial docs #4395
Conversation
website/content/en/docs/building-operators/ansible/quickstart.md
Outdated
Show resolved
Hide resolved
5f65168
to
c5c4e66
Compare
Thanks for the review and comments @estroz. I replied inline to your feedback. |
website/content/en/docs/building-operators/golang/quickstart.md
Outdated
Show resolved
Hide resolved
c5c4e66
to
1944761
Compare
Updates and feedback provided inline. Thanks for review @camilamacedo86 @estroz. |
@camilamacedo86 @estroz Found the issue with the test suite and responded in #4395 (comment). Just wondering if a note should be added until a fix becomes available? |
1944761
to
7023f45
Compare
Fix issues in the operaor-sdk docs.. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
7023f45
to
eca3e3d
Compare
Updated following latest review comments from @estroz. It is good for review again @camilamacedo86 @estroz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the reviews @camilamacedo86 and @estroz and the merge @estroz. |
@hickeyma thanks a ton for the contribution! |
Fix issues in the operaor-sdk docs.. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Fix issues in the operaor-sdk docs.. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Fix issues in the operaor-sdk docs.. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Fix issues in the operaor-sdk docs.. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Fix issues in the operaor-sdk docs.. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>Signed-off-by: rearl <rearl@secureworks.com>
Description of the change:
While using the operator-sdk docs, I encountered the following issues:
make docker-build IMG=hub.docker.com/$USERNAME/memcached-operator:v0.0.1
in https://sdk.operatorframework.io/docs/building-operators/golang/tutorial/#build-and-push-the-image:InstallingRef: Issue #4203.kubebuilder
fixes the issue.kubectl get deployment
command should not displaymemcached-operator-controller-manager
as it is not in the default namespaceMotivation for the change:
Improve the docs.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs