Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[OC-1468] Addressing CommonJs dependencies warnings #789

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

AlexGuironnetRTE
Copy link
Member

@AlexGuironnetRTE AlexGuironnetRTE commented Feb 11, 2021

Explanations

For the items for which no satisfactory ES module equivalent exists, I added them under allowedCommonJsDependencies in angular.json to suppress the warning until it can be fixed.

Dependencies in our code:

Indirect dependencies

Release notes

under tasks, OC-1468 Addressing CommonJs dependencies warnings

@AlexGuironnetRTE
Copy link
Member Author

file-saver -> solved thanks to @HarelM's comment on eligrey/FileSaver.js#538

@vlo-rte vlo-rte self-assigned this Feb 12, 2021
@vlo-rte vlo-rte merged commit b231aa1 into develop Feb 12, 2021
@vlo-rte vlo-rte deleted the OC-1468 branch February 12, 2021 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants