Skip to content

Commit

Permalink
fixed unit tests
Browse files Browse the repository at this point in the history
Signed-off-by: Harish P <harish_p4@dell.com>
  • Loading branch information
harishp8889 committed Dec 16, 2022
1 parent e9dbeb1 commit 159c6f5
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions goopicsi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func (suite *GoopcsiTestSuite) TearDownTestSuite() {
suite.T().Log("Cleaning up resources..")
}

// TODO These test cases should be reverted with mock server implementation
// func TestNVMeControllerConnect(t *testing.T) {
// err := NVMeControllerConnect("12", "", "", 44565, "")
// if err != nil {
Expand Down Expand Up @@ -113,6 +114,15 @@ func (suite *GoopcsiTestSuite) TearDownTestSuite() {
// log.Println(resp)
// }

// func TestExposeRemoteNVMe(t *testing.T) {
// subsystemID, controllerID, err := ExposeRemoteNVMe("nqn.2022-09.io.spdk:test", 10)
// if err != nil {
// log.Println(err)
// }
// log.Printf("Subsystem ID: %s", subsystemID)
// log.Printf("Controller Id: %s", controllerID)
// }

func (suite *GoopcsiTestSuite) TestDeleteNVMeNamespace() {
// positive scenario
err := DeleteNVMeNamespace("1")
Expand All @@ -123,15 +133,6 @@ func (suite *GoopcsiTestSuite) TestDeleteNVMeNamespace() {
assert.Error(suite.T(), err, "DeleteNVMeNamespace failed")
}

// func TestExposeRemoteNVMe(t *testing.T) {
// subsystemID, controllerID, err := ExposeRemoteNVMe("nqn.2022-09.io.spdk:test", 10)
// if err != nil {
// log.Println(err)
// }
// log.Printf("Subsystem ID: %s", subsystemID)
// log.Printf("Controller Id: %s", controllerID)
// }

func TestGenerateHostNQN(t *testing.T) {
hostNQN := GenerateHostNQN()
log.Println(hostNQN)
Expand Down

0 comments on commit 159c6f5

Please # to comment.