-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added CreateNamespace RPC #45
Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 31.57% 34.91% +3.33%
==========================================
Files 1 1
Lines 171 169 -2
==========================================
+ Hits 54 59 +5
+ Misses 112 106 -6
+ Partials 5 4 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
77aa0f5
to
efd030c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVMeControllerConnect
, NVMeControllerConnect
and CreateNVMeNamespace
should not return protobuf message as a return value. instead just string/int/error maybe
otherwise implementation and user are tightly coupled and forces user to know about protobufs. if library changes in the future to support REST, for example, the user of the library should not be affected by it...
48c1b58
to
e5d76d9
Compare
df651d5
to
6cecc80
Compare
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Harish P <harish_p4@dell.com>
f5ef2e9
to
43e1fda
Compare
Signed-off-by: Boris Glimcher <36732377+glimchb@users.noreply.github.com>
Signed-off-by: Harish P <harish_p4@dell.com>
Signed-off-by: Harish P harish_p4@dell.com