-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[storage][front-end] Remove xxxGetResponse xxxUpdateResponse messages #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
glimchb
commented
Nov 2, 2022
- [storage][front-end] Remove xxxUpdateResponse messages
- [storage][front-end] Remove xxxGetResponse messages
- [storage] auto-generate protos
Following Google AIP-134 - Standard methods: Update Related to opiproject#174 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Following Google AIP-131 - Standard methods: Get Related to opiproject#174 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
benlwalker
approved these changes
Nov 2, 2022
mkalderon
approved these changes
Nov 2, 2022
PWAlessi
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#183 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
mestery
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STAMP
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#183 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
jainvipin
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#183 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#183 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
mestery
pushed a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 2, 2022
see opiproject/opi-api#183 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Merge Candidate
in the open merge window, next candidate for merge
Storage
APIs or code related to storage area
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.