Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[storage][front-end] Remove xxxGetResponse xxxUpdateResponse messages #183

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Nov 2, 2022

  • [storage][front-end] Remove xxxUpdateResponse messages
  • [storage][front-end] Remove xxxGetResponse messages
  • [storage] auto-generate protos

Following Google AIP-134 - Standard methods: Update

Related to opiproject#174

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Following Google AIP-131 - Standard methods: Get

Related to opiproject#174

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb requested a review from a team as a code owner November 2, 2022 14:56
@glimchb glimchb self-assigned this Nov 2, 2022
@glimchb glimchb added Storage APIs or code related to storage area Merge Candidate in the open merge window, next candidate for merge labels Nov 2, 2022
Copy link
Contributor

@PWAlessi PWAlessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Nov 2, 2022
see opiproject/opi-api#183

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STAMP

glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Nov 2, 2022
see opiproject/opi-api#183

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Copy link
Contributor

@jainvipin jainvipin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glimchb glimchb merged commit 3c744e3 into opiproject:main Nov 2, 2022
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Nov 2, 2022
see opiproject/opi-api#183

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Nov 2, 2022
see opiproject/opi-api#183

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
mestery pushed a commit to opiproject/opi-spdk-bridge that referenced this pull request Nov 2, 2022
see opiproject/opi-api#183

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Merge Candidate in the open merge window, next candidate for merge Storage APIs or code related to storage area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants