Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added changelog file. #167

Closed
wants to merge 1 commit into from

Conversation

intelfisz
Copy link
Collaborator

No description provided.

@intelfisz intelfisz requested a review from a team as a code owner July 6, 2023 14:46
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #167 (8b585a1) into main (875e957) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files           4        4           
  Lines         372      372           
=======================================
  Hits          367      367           
  Misses          4        4           
  Partials        1        1           

@intelfisz intelfisz force-pushed the feat-add-changelog branch from 5947326 to 8b585a1 Compare July 6, 2023 14:50
@intelfisz
Copy link
Collaborator Author

Under review - please do not merge yet

@glimchb
Copy link
Member

glimchb commented Jul 6, 2023

Under review - please do not merge yet

@intelfisz you can mark PRs as draft if not ready to merge

@glimchb glimchb marked this pull request as draft July 6, 2023 15:34
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is the best approach...
because github auto-creates changelog for you when you create a release...
example https://github.com/opiproject/opi-spdk-bridge/releases
but it can be formatted as you like...

@intelfisz
Copy link
Collaborator Author

intelfisz commented Jul 6, 2023

@glimchb - thanks for the hint but...
I want to have a clean and meaningful backlog and not just a listing from git log - BTW this is an anti-pattern, see https://keepachangelog.com/en/1.1.0/#bad-practices.

@glimchb
Copy link
Member

glimchb commented Jul 6, 2023

@glimchb - thanks for the hint but... I want to have a clean and meaningful backlog and not just a listing from git log - BTW this is an anti-pattern, see https://keepachangelog.com/en/1.1.0/#bad-practices.

make sense. but when you create a release you can clean up the change log as you wish and format it...

another option is use changelog.md file and then when you create github release, give the changelog file to github to use...

anyways I want to avoid have 2 different things in 2 places...

you can experiment on your private fork of the repo to see what works for you...

Signed-off-by: Filip Szufnarowski <filip.szufnarowski@intel.com>
@intelfisz intelfisz force-pushed the feat-add-changelog branch from 8b585a1 to c3e4214 Compare July 10, 2023 14:51
@intelfisz
Copy link
Collaborator Author

@glimchb - thanks for the hint but... I want to have a clean and meaningful backlog and not just a listing from git log - BTW this is an anti-pattern, see https://keepachangelog.com/en/1.1.0/#bad-practices.

make sense. but when you create a release you can clean up the change log as you wish and format it...

another option is use changelog.md file and then when you create github release, give the changelog file to github to use...

anyways I want to avoid have 2 different things in 2 places...

you can experiment on your private fork of the repo to see what works for you...

yes, we don't want to maintain same thing in 2 places. we will keep a changelog (with unreleased section to be filled in on the fly) and when doing GH Release we will provide there links to the respective changelog release sections.

@intelfisz intelfisz closed this Jul 14, 2023
@intelfisz intelfisz deleted the feat-add-changelog branch July 14, 2023 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants