-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added changelog file. #167
Conversation
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 4 4
Lines 372 372
=======================================
Hits 367 367
Misses 4 4
Partials 1 1 |
5947326
to
8b585a1
Compare
Under review - please do not merge yet |
@intelfisz you can mark PRs as draft if not ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is the best approach...
because github auto-creates changelog for you when you create a release...
example https://github.com/opiproject/opi-spdk-bridge/releases
but it can be formatted as you like...
@glimchb - thanks for the hint but... |
make sense. but when you create a release you can clean up the change log as you wish and format it... another option is use changelog.md file and then when you create github release, give the changelog file to github to use... anyways I want to avoid have 2 different things in 2 places... you can experiment on your private fork of the repo to see what works for you... |
Signed-off-by: Filip Szufnarowski <filip.szufnarowski@intel.com>
8b585a1
to
c3e4214
Compare
yes, we don't want to maintain same thing in 2 places. we will keep a changelog (with unreleased section to be filled in on the fly) and when doing GH Release we will provide there links to the respective changelog release sections. |
No description provided.