Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: adding evpn use case files to opi-intel-bridge #491

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

atulpatel261194
Copy link
Contributor

Initial implementation for transition from opi-evpn-bridge to opi-intel-bridge
This PR includes the following changes:

Moving vendor plugin from PR386 to opi-intel-bridge
Moving LinuxVendorModule to opi-intel-bridge
Restructuring to accommodate both storage and evpn binaries

    Co-authored-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
    Co-authored-by: Saikumar Banoth <banoth.saikumar@intel.com>
    Co-authored-by: Patel Atul <Atul.patel@intel.com>
    Co-authored-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
    Co-authored-by: Jambekar Vishakha <vishakha.jambekar@intel.com>
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Copy link
Collaborator

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update bin names in README.md

@atulpatel261194 atulpatel261194 force-pushed the evpnUseCase branch 2 times, most recently from b341d20 to 5a711ad Compare August 30, 2024 11:50
    Co-authored-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
    Co-authored-by: Saikumar Banoth <banoth.saikumar@intel.com>
    Co-authored-by: Patel Atul <Atul.patel@intel.com>
    Co-authored-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
    Co-authored-by: Jambekar Vishakha <vishakha.jambekar@intel.com>

Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
@atulpatel261194 atulpatel261194 marked this pull request as ready for review September 2, 2024 07:40
@atulpatel261194 atulpatel261194 requested a review from a team as a code owner September 2, 2024 07:40
@atulpatel261194 atulpatel261194 force-pushed the evpnUseCase branch 2 times, most recently from 962a871 to 1ccdeb2 Compare September 2, 2024 14:44
cmd/evpn/main.go Outdated
frr.Initialize()
ipu_vendor.Initialize()

case "ci":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need ci here if it is a vendor xpu?

cmd/evpn/main.go Outdated

// initialize cobra config
if err := initialize(); err != nil {
// log.Println(err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please cleanup of commented code

Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
@artek-koltun
Copy link
Collaborator

#493
#494
#495

@artek-koltun artek-koltun merged commit f71e1a7 into opiproject:main Sep 4, 2024
16 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants