Fixed #140 accel_crypto_key_create missing Key2 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 49.67% 49.67%
=======================================
Files 4 4
Lines 1224 1226 +2
=======================================
+ Hits 608 609 +1
- Misses 598 599 +1
Partials 18 18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
glimchb
force-pushed
the
glimchb-patch-1
branch
from
6db025f to
6901d7a
Compare
Signed-off-by: Boris Glimcher <36732377+glimchb@users.noreply.github.com> Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
force-pushed
the
glimchb-patch-1
branch
from
6901d7a to
51deb7d
Compare
seroyer
approved these changes
Feb 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key2is marked as optional but SPDK mandates it in the code still...https://spdk.io/doc/jsonrpc.html#rpc_accel_crypto_key_create
Signed-off-by: Boris Glimcher 36732377+glimchb@users.noreply.github.com