Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add FirmwareRevision #62

Merged
merged 1 commit into from
Nov 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server/frontend.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,22 @@ func (s *server) CreateNVMeSubsystem(ctx context.Context, in *pb.CreateNVMeSubsy
log.Printf("error: %v", err)
return nil, err
}
subsystems[in.Subsystem.Spec.Id.Value] = in.Subsystem
log.Printf("Received from SPDK: %v", result)
var ver GetVersionResult
err = call("spdk_get_version", nil, &ver)
if err != nil {
log.Printf("error: %v", err)
return nil, err
}
log.Printf("Received from SPDK: %v", ver)
response := &pb.NVMeSubsystem{}
err = deepcopier.Copy(in.Subsystem).To(response)
if err != nil {
log.Printf("error: %v", err)
return nil, err
}
response.Status = &pb.NVMeSubsystemStatus{FirmwareRevision: ver.Version}
subsystems[in.Subsystem.Spec.Id.Value] = response
return response, nil
}

Expand Down
11 changes: 11 additions & 0 deletions server/spdk.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ package main
// vhost_delete_controller
// vhost_get_controllers

// GetVersionResult is the result of getting a version
type GetVersionResult struct {
Version string `json:"version"`
Fields struct {
Major int `json:"major"`
Minor int `json:"minor"`
Patch int `json:"patch"`
Suffix string `json:"suffix"`
} `json:"fields"`
}

// BdevAioCreateParams holds the parameters required to create an AIO Block Device
type BdevAioCreateParams struct {
Name string `json:"name"`
Expand Down