Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tests: call go test #8

Merged
merged 1 commit into from
Oct 21, 2022
Merged

tests: call go test #8

merged 1 commit into from
Oct 21, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 21, 2022

will add tests later on

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb requested a review from a team as a code owner October 21, 2022 16:43
@glimchb glimchb requested a review from PWAlessi October 21, 2022 16:43
@glimchb
tests: call go test
c0ac01e 
will add tests later on

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
mestery
mestery approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but I don't see any unit tests however.

@glimchb
Copy link
Member Author

glimchb commented Oct 21, 2022

OK, but I don't see any unit tests however.

baby steps

@glimchb glimchb merged commit 3725652 into opiproject:main Oct 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mestery mestery mestery approved these changes

@PWAlessi PWAlessi Awaiting requested review from PWAlessi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glimchb @mestery