Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: test nvme entities over HTTP #878

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

artek-koltun
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c467a92) 74.89% compared to head (6cb6787) 74.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   74.89%   74.89%           
=======================================
  Files          40       40           
  Lines        3693     3693           
=======================================
  Hits         2766     2766           
  Misses        839      839           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mention an example for HTTP in the readme page as well

@artek-koltun artek-koltun force-pushed the run-http-gateway branch 5 times, most recently from a00b051 to 87a21f9 Compare February 1, 2024 08:27
@artek-koltun artek-koltun changed the title test(backend): test nvme entities over HTTP test: test nvme entities over HTTP Feb 1, 2024
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI failure 500 is fixed

curl: (22) The requested URL returned error: 500

from https://github.com/opiproject/opi-spdk-bridge/actions/runs/7740869173/job/21106738684?pr=878

@artek-koltun
Copy link
Contributor Author

artek-koltun commented Feb 2, 2024

lgtm once CI failure 500 is fixed

curl: (22) The requested URL returned error: 500

from https://github.com/opiproject/opi-spdk-bridge/actions/runs/7740869173/job/21106738684?pr=878

This is fixed in those PRs
#880
opiproject/godpu#438
please take a look

Also, I am thinking to move the tests from the script file into docker-compose

@artek-koltun artek-koltun marked this pull request as ready for review February 5, 2024 07:26
@artek-koltun artek-koltun requested a review from a team as a code owner February 5, 2024 07:26
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
Copy link
Contributor Author

Merging as is. Let's discuss how to organize http tests in Slack

@artek-koltun artek-koltun merged commit 121357d into opiproject:main Feb 5, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants