-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Schema Library Integration #111
Conversation
FragmentedPacket
commented
Dec 13, 2024
- Clone down repo into root directory of Emma.
- Will pull or use existing repo and attempt to pull in 1hr (Maybe we just get rid of this, but added just so we can update it at some point)
- Add logic to determine what schemas have already been loaded.
…hat schemas have already been loaded.
Looks good! Still have a small issue with the following:
I feel like the part responsible to pin already loaded schema isn't working well in that case :/ |
…t wasn't pulling latest loaded schemas to disable button, etc.
Ok, I think I have it figured out now! I refactored the Let me know if the behaviour is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the invalidity of the cache was not perfect so we can remove it until we have something proper. I got similar issue in my other PR.