Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Schema Library Integration #111

Merged
merged 7 commits into from
Dec 21, 2024
Merged

Conversation

FragmentedPacket
Copy link
Contributor

  • Clone down repo into root directory of Emma.
  • Will pull or use existing repo and attempt to pull in 1hr (Maybe we just get rid of this, but added just so we can update it at some point)
  • Add logic to determine what schemas have already been loaded.

@FragmentedPacket FragmentedPacket requested a review from a team December 13, 2024 18:26
@BaptisteGi
Copy link
Contributor

Looks good!

Still have a small issue with the following:

  • Load base & a few extensions
  • Reload the page
    -> I need to "load base to infrahub" again before having the extension section displayed

I feel like the part responsible to pin already loaded schema isn't working well in that case :/

…t wasn't pulling latest loaded schemas to disable button, etc.
@FragmentedPacket
Copy link
Contributor Author

Looks good!

Still have a small issue with the following:

  • Load base & a few extensions
  • Reload the page
    -> I need to "load base to infrahub" again before having the extension section displayed

I feel like the part responsible to pin already loaded schema isn't working well in that case :/

Ok, I think I have it figured out now! I refactored the init_schema_extension_state a little bit and then removed the cache from the get_schema call as it was using stale data and thus not being able to see the new schemas loaded. I didn't notice any performance issues on a blank slate instance with multiple refreshes, etc.

Let me know if the behaviour is resolved.

Copy link
Contributor

@BeArchiTek BeArchiTek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the invalidity of the cache was not perfect so we can remove it until we have something proper. I got similar issue in my other PR.

@FragmentedPacket FragmentedPacket merged commit 6310bc3 into main Dec 21, 2024
2 checks passed
@FragmentedPacket FragmentedPacket deleted the may-2024-git-clone-schema-library branch December 21, 2024 21:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants