Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Polish tranquilo interface #390

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Polish tranquilo interface #390

merged 2 commits into from
Oct 16, 2022

Conversation

mpetrosian
Copy link
Member

@mpetrosian mpetrosian commented Oct 15, 2022

  • add docstring to main tranquilo function.
  • make some hard-coded values arguments of the main tranquilo function

@mpetrosian mpetrosian requested a review from janosg October 15, 2022 10:23
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #390 (e64a92c) into main (e4c7c93) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   92.61%   92.60%   -0.02%     
==========================================
  Files         207      207              
  Lines       16097    16100       +3     
==========================================
  Hits        14909    14909              
- Misses       1188     1191       +3     
Impacted Files Coverage Δ
src/estimagic/optimization/pounders.py 93.98% <ø> (ø)
src/estimagic/optimization/tranquilo/fit_models.py 78.28% <80.00%> (+0.28%) ⬆️
src/estimagic/optimization/tranquilo/tranquilo.py 91.85% <100.00%> (+0.06%) ⬆️
...magic/optimization/subsolvers/_trsbox_quadratic.py 84.89% <0.00%> (-0.82%) ⬇️
...ptimization/subsolvers/bounded_newton_quadratic.py 85.96% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janosg janosg merged commit 0cd0b18 into main Oct 16, 2022
@janosg janosg deleted the polish-tranquilo-interface branch October 16, 2022 08:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants