Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add poisedness check for sample quality #399

Merged
merged 38 commits into from
Jan 15, 2023
Merged

Add poisedness check for sample quality #399

merged 38 commits into from
Jan 15, 2023

Conversation

segsell
Copy link
Member

@segsell segsell commented Nov 10, 2022

Add function to calculate the lambda poisedness of a sample.

Note that we move to black python version 3.10 in .pre-commit-config.yaml.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #399 (4a52526) into main (608dc5c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   92.82%   92.86%   +0.04%     
==========================================
  Files         223      225       +2     
  Lines       17459    17589     +130     
==========================================
+ Hits        16206    16334     +128     
- Misses       1253     1255       +2     
Impacted Files Coverage Δ
src/estimagic/optimization/tranquilo/geometry.py 96.87% <ø> (ø)
src/estimagic/optimization/tranquilo/poisedness.py 100.00% <100.00%> (ø)
tests/optimization/tranquilo/test_poisedness.py 100.00% <100.00%> (ø)
src/estimagic/optimization/subsolvers/_trsbox.py 84.95% <0.00%> (-0.82%) ⬇️
src/estimagic/optimization/subsolvers/bntr.py 87.20% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@segsell segsell requested a review from janosg December 21, 2022 14:55
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks!

@janosg janosg merged commit e9d4cd6 into main Jan 15, 2023
@janosg janosg deleted the poisedness branch January 15, 2023 13:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants