Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor subsolvers #400

Merged
merged 8 commits into from
Nov 12, 2022
Merged

Refactor subsolvers #400

merged 8 commits into from
Nov 12, 2022

Conversation

mpetrosian
Copy link
Member

Define each subsolver in its separate module.

@mpetrosian mpetrosian requested a review from janosg November 11, 2022 14:09
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #400 (4bbd9c4) into main (2f968f3) will decrease coverage by 0.00%.
The diff coverage is 97.01%.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   92.88%   92.87%   -0.01%     
==========================================
  Files         213      212       -1     
  Lines       17140    17111      -29     
==========================================
- Hits        15920    15892      -28     
+ Misses       1220     1219       -1     
Impacted Files Coverage Δ
src/estimagic/optimization/subsolvers/bntr.py 87.20% <94.54%> (ø)
src/estimagic/optimization/subsolvers/gqtpar.py 90.66% <96.00%> (ø)
src/estimagic/optimization/pounders_auxiliary.py 97.33% <100.00%> (ø)
...timagic/optimization/tranquilo/solve_subproblem.py 88.46% <100.00%> (ø)
tests/optimization/test_quadratic_subsolvers.py 100.00% <100.00%> (ø)
tests/optimization/tranquilo/test_bntr_fast.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janosg janosg merged commit 0606165 into main Nov 12, 2022
@janosg janosg deleted the refactor-subsolvers branch November 12, 2022 09:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants