-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update scaling argument handling #508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice but gave me some additional ideas we need to discuss.
tests/optimagic/optimization/test_optimizations_with_scaling.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.5.0 #508 +/- ##
========================================
Coverage ? 90.37%
========================================
Files ? 102
Lines ? 9493
Branches ? 0
========================================
Hits ? 8579
Misses ? 914
Partials ? 0 ☔ View full report in Codecov by Sentry. |
In this PR, I update the scaling argument handling.
scaling_options
argument is usedScalingOptions
toscaling
argumentcheck_arguments.py
Note
I chose to stick with the
ScalingOptionsDict
, as it gives you autocomplete in the editor. See below.