Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add NumdiffResult object #514

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Add NumdiffResult object #514

merged 13 commits into from
Aug 6, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Aug 5, 2024

  • Update pre-commit hooks and add numpy to pre-commit mypy environment
  • Add NumdiffResult object
  • Add type hints to the first and second derivative outer interface
  • Deprecate Richardson extrapolation options as well as return_func_value argument
  • Test deprecations
  • Update documentation

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/optimagic/differentiation/derivatives.py 98.38% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/optimagic/deprecations.py 100.00% <100.00%> (ø)
src/optimagic/optimization/optimize_result.py 93.98% <100.00%> (ø)
src/optimagic/differentiation/derivatives.py 98.05% <98.38%> (ø)

@timmens timmens changed the title Add numdiffresult object Add NumdiffResult object Aug 5, 2024
@timmens timmens requested a review from janosg August 5, 2024 13:55
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR. I just have comments about the documentation.

@timmens timmens requested a review from janosg August 6, 2024 16:23
@timmens timmens merged commit b16444b into 0.5.0 Aug 6, 2024
16 checks passed
@timmens timmens deleted the add-numdiffresult-object branch August 6, 2024 17:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants