Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update numdiff option handling #517

Merged
merged 46 commits into from
Aug 10, 2024
Merged

Update numdiff option handling #517

merged 46 commits into from
Aug 10, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Aug 8, 2024

  • Create a NumdiffOptions class
  • Update documentation
  • Deprecate numdiff_options in estimation functions
  • Allow PyTrees in derivative arguments

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 95.36082% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/estimagic/estimate_ml.py 88.13% 7 Missing ⚠️
src/estimagic/estimate_msm.py 97.43% 1 Missing ⚠️
src/estimagic/examples/logit.py 92.30% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/estimagic/__init__.py 100.00% <100.00%> (ø)
src/estimagic/bootstrap.py 99.06% <100.00%> (ø)
src/estimagic/bootstrap_ci.py 100.00% <100.00%> (ø)
src/estimagic/bootstrap_helpers.py 100.00% <ø> (ø)
src/estimagic/bootstrap_outcomes.py 100.00% <100.00%> (ø)
src/estimagic/bootstrap_samples.py 100.00% <ø> (ø)
src/estimagic/config.py 100.00% <ø> (ø)
src/estimagic/estimation_table.py 84.36% <100.00%> (ø)
src/estimagic/lollipop_plot.py 100.00% <100.00%> (ø)
src/estimagic/ml_covs.py 84.14% <100.00%> (ø)
... and 94 more

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janosg janosg merged commit f9f773f into 0.5.0 Aug 10, 2024
14 checks passed
@janosg janosg deleted the numdiff-options branch August 10, 2024 08:08
@janosg janosg restored the numdiff-options branch August 10, 2024 08:10
@timmens timmens deleted the numdiff-options branch August 25, 2024 12:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants