Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(ATS): pass odp common data and identifiers to java core #445

Merged
merged 3 commits into from
Jan 18, 2023
Merged

feat(ATS): pass odp common data and identifiers to java core #445

merged 3 commits into from
Jan 18, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jan 17, 2023

Summary

Pass android ODP commonData and commonIdentifiers to Java ODPManager builder.

Test plan

  • Add a unit test/

Issues

  • FSSDK-8768

@jaeopt jaeopt requested a review from a team as a code owner January 17, 2023 21:32
@jaeopt jaeopt removed their assignment Jan 17, 2023
mnoman09
mnoman09 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 67a3008 into master Jan 18, 2023
@jaeopt jaeopt deleted the jae/with-user-common-data branch January 18, 2023 16:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mnoman09 mnoman09 mnoman09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaeopt @mnoman09