-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[FSSDK-10758] implement vuid configuration independent of odp #497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, where do we check client_initialized event based on vuid enable status.
this was already implemented here: android-sdk/android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyClient.java Line 83 in eebed3c
This will drop any event if there is no valid identifier but there will be a error log. I have added a new condition to check whether the vuid is not null to avoid the log: 3512a65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - with a small fix suggestion
@Synchronized | ||
fun configure(enableVuid: Boolean, context: Context) { | ||
if (!enableVuid) { | ||
removeVuid(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removeVuid(context) | |
removeVuid(context) | |
self.vuid = null |
Summary
Test plan
Issues