Skip to content

[FSSDK-9079] fix: send odp event empty values #346

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 18, 2023
Merged

[FSSDK-9079] fix: send odp event empty values #346

merged 9 commits into from
Apr 18, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Validate SendOdpEvent empty action and type parameters
  • Generate new idempotence_id for every OdpEvent

Test plan

added tests to:

  • OdpEventManagerTests.cs
  • OptimizelyTest.cs

Ticket

FSSDK-9079

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review April 17, 2023 16:40
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner April 17, 2023 16:40
mikechu-optimizely
mikechu-optimizely requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to consider 👇

@mikechu-optimizely mikechu-optimizely removed their assignment Apr 17, 2023
mikechu-optimizely
mikechu-optimizely approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙏

jaeopt
jaeopt requested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of changes suggested.

jaeopt
jaeopt approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikechu-optimizely
mikechu-optimizely approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit d9a6e9a into master Apr 18, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/send_odp_event_empty_values branch April 18, 2023 20:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @jaeopt @mikechu-optimizely