-
Notifications
You must be signed in to change notification settings - Fork 20
[FSSDK-9128] fix: Handle ODP INVALID_IDENTIFIER_EXCEPTION code #348
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
instead of InvalidIdentifierException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see a logic change to provide proper error message for INVALID_IDENTIFIER_EXCEPTION. Can you check again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The error "code" is optional. Can you check if we have a test case without code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Support a new format for ODP
InvalidIdentifierException
(when SDK fetches segments with a non-registered userId).Test plan
Issues