Skip to content

[FSSDK-9538] bug: Fix last modified formatting #361

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Jul 24, 2023

Summary

Test plan

  • Updated existing unit tests to look for correct formatting
  • All other existing tests should continue to pass.

Issues

  • FSSDK-9538

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review July 24, 2023 21:24
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner July 24, 2023 21:24
@mikechu-optimizely mikechu-optimizely changed the title [FSSDK-9533] bug: Fix last modified formatting [FSSDK-9538] bug: Fix last modified formatting Jul 25, 2023
@mikechu-optimizely
Copy link
Contributor Author

This will need to be part of a cherry-pick and release for a v3.11.4 along with #362

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 962bd68 into master Jul 25, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/fix-last-modified-format branch July 25, 2023 17:04
mikechu-optimizely added a commit that referenced this pull request Jul 26, 2023
* Fix non-RFC1123 formatting

* Update tests to ensure expected format

* Add more accurate assert

* Lint fixes

(cherry picked from commit 962bd68)
mikechu-optimizely added a commit that referenced this pull request Jul 26, 2023
* Fix non-RFC1123 formatting

* Update tests to ensure expected format

* Add more accurate assert

* Lint fixes

(cherry picked from commit 962bd68)
mikechu-optimizely added a commit that referenced this pull request Jul 28, 2023
* [FSSDK-9538] bug: Fix last modified formatting (#361)

* Fix non-RFC1123 formatting

* Update tests to ensure expected format

* Add more accurate assert

* Lint fixes

(cherry picked from commit 962bd68)

* Update CI to run for release branch

* Update (fix) assembly versions

I can't believe I missed the main project fully 😫

* Update CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants