Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update compiler config default results_format to binary_count #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update compiler config default results_format to binary_count #9

wants to merge 2 commits into from

Conversation

hwaring-oqc
Copy link

No description provided.

@bsach-oqc
Copy link

Looks sensible up to fears that we're relying on the current default. @lcauser-oqc is running some checks.

bsach-oqc
bsach-oqc requested changes Feb 18, 2025
View reviewed changes
Copy link

@bsach-oqc bsach-oqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks QAT tests. We will make an internal compiler team ticket to make the default behaviour binary_count either by enabling this change or an equivalent.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bsach-oqc bsach-oqc bsach-oqc requested changes

@owen-oqc owen-oqc Awaiting requested review from owen-oqc owen-oqc is a code owner

@hamidelmaazouz hamidelmaazouz Awaiting requested review from hamidelmaazouz hamidelmaazouz is a code owner

@bgsach bgsach Awaiting requested review from bgsach bgsach is a code owner

@lcauser-oqc lcauser-oqc Awaiting requested review from lcauser-oqc lcauser-oqc is a code owner

@alillistone-oqc alillistone-oqc Awaiting requested review from alillistone-oqc alillistone-oqc is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwaring-oqc @bsach-oqc