Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Instruction list optimisation and result processing passes. #271

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Instruction list optimisation and result processing passes. #271

merged 2 commits into from
Nov 27, 2024

Conversation

keriksson-rosenqvist-oqc
Copy link
Contributor

@keriksson-rosenqvist-oqc keriksson-rosenqvist-oqc commented Nov 26, 2024 •
edited
Loading

Use pipelines to do instruction optimisations and results processing in the QAT().execute method.

Keep in mind this is the rough first draft and there are improvements to the pipeline setup coming in @bgsach's work really soon.

@github-actions GitHub Actions
Copy link

Performance Regression Tests

Performance changes detected in the following benchmarks: none

Pusher: @keriksson-rosenqvist, Action: pull_request, Workflow: Performance regression tests

hamidelmaazouz
hamidelmaazouz approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@hamidelmaazouz hamidelmaazouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions

src/qat/compiler/validation_passes.py Show resolved Hide resolved
src/qat/backend/validation_passes.py Show resolved Hide resolved
src/qat/core.py Show resolved Hide resolved
src/qat/core.py Show resolved Hide resolved
tests/qat/test_core.py Show resolved Hide resolved
src/qat/runtime/transform_passes.py Outdated Show resolved Hide resolved
src/qat/runtime/transform_passes.py Show resolved Hide resolved
src/qat/core.py Show resolved Hide resolved
@hamidelmaazouz hamidelmaazouz self-requested a review November 26, 2024 23:00
@hamidelmaazouz hamidelmaazouz mentioned this pull request Nov 26, 2024
Closed
dvanhende-oqc
dvanhende-oqc approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@dvanhende-oqc dvanhende-oqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I especially like the explicit type hints for QuantumHardwareModel as the interchangeable use of a QuantumHardwareModel and ExecutionEngine for a model was quite confusing at times 🙂

src/qat/backend/validation_passes.py Show resolved Hide resolved
lcauser-oqc
lcauser-oqc approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@lcauser-oqc lcauser-oqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!!

src/qat/runtime/transform_passes.py Outdated Show resolved Hide resolved
@keriksson-rosenqvist-oqc keriksson-rosenqvist-oqc force-pushed the experimental/ker/execute_passes branch from 7d07031 to e628bcc Compare November 27, 2024 14:05
@keriksson-rosenqvist-oqc keriksson-rosenqvist-oqc merged commit adbad04 into main Nov 27, 2024
21 checks passed
@keriksson-rosenqvist-oqc keriksson-rosenqvist-oqc deleted the experimental/ker/execute_passes branch November 27, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@keriksson-rosenqvist-oqc keriksson-rosenqvist-oqc added enhancement New feature or request experimental Experimental features (not enabled by default) labels Nov 27, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lcauser-oqc lcauser-oqc lcauser-oqc approved these changes

@dvanhende-oqc dvanhende-oqc dvanhende-oqc approved these changes

@owen-oqc owen-oqc Awaiting requested review from owen-oqc

@bgsach bgsach Awaiting requested review from bgsach

@hamidelmaazouz hamidelmaazouz Awaiting requested review from hamidelmaazouz

Assignees

@keriksson-rosenqvist-oqc keriksson-rosenqvist-oqc

Labels
enhancement New feature or request experimental Experimental features (not enabled by default)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keriksson-rosenqvist-oqc @hamidelmaazouz @dvanhende-oqc @lcauser-oqc