Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

move HtmlText caching from repository to service layer #4520

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

sbwalker
Copy link
Member

No description provided.

@sbwalker sbwalker merged commit 513d2a8 into oqtane:dev Aug 14, 2024
@leigh-pointer
Copy link
Contributor

Ok, but why? interested!

@sbwalker
Copy link
Member Author

sbwalker commented Aug 14, 2024

@leigh-pointer the Search Indexer Job runs every minute by default and indexes every HtmlText module in a site. Due to the fact that caching was implemented in the Repository layer it meant that the content of every HtmlText module would be loaded into memory. Although this is good for performance, it is not good for overall memory utilization on the server as these items will never be expired from the cache (since they are referenced every minute). By moving caching to the service layer it means that the UI will serve HtmlText content from the cache - but if that content is not accessed for 30 minutes it will be flushed from the cache - resulting in more efficient memory utilization on the server. The Search Indexer Job will call the repository without any caching - which is fine because it is happening in a background process.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants