Skip to content

dbt-oracle v1.5.0 #84

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
May 9, 2023
Merged

dbt-oracle v1.5.0 #84

merged 7 commits into from
May 9, 2023

Conversation

aosingh
Copy link
Member

@aosingh aosingh commented May 9, 2023

Addresses #83

  1. Model Contracts

    • Implement data_type_code_to_name to convert Python connector return types to strings

    • Implement oracle__get_empty_subquery_sql and oracle__get_empty_schema_sql to generate SQL to assert column spec equivalence

    • Updated macro create_table_as add calls to two macros that assert column spec equivalence and template out DDL containing column names, types, and constraints

    • Updated macro create_view_as add a call to the macro asserting column spec equivalence

    • Support the constraints data structure

      • Map constraint types to CONSTRAINT_SUPPORT
      • Override Adapter method render_column_constraint
  2. Dependencies dbt-core and oracledb upgraded

  3. Lots of new test cases

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 9, 2023
@aosingh aosingh merged commit f736c18 into main May 9, 2023
@aosingh aosingh deleted the dev/v1.5 branch May 12, 2023 20:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants