Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[GR-60176] JFR Old Object Sampler fixes #10190

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[GR-60176] JFR Old Object Sampler fixes #10190

merged 2 commits into from
Dec 2, 2024

Conversation

roberttoyonaga
Copy link
Collaborator

A couple small fixes. To address the errors found here: #10154 (comment)

  1. Fix an incorrect assertion. Previously when a younger sample neighbor could not be found, we assumed that the queue was empty. This is not true. It might just be the case that the sample being removed already is the youngest in the queue, so has no younger neighbor.
  2. Initialize JFR before running the JFR leak profiler tests. Please see code comment for explanation.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 28, 2024
@roberttoyonaga roberttoyonaga self-assigned this Nov 28, 2024
@roberttoyonaga roberttoyonaga added native-image redhat-interest native-image-jfr and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Nov 28, 2024
@roberttoyonaga roberttoyonaga mentioned this pull request Nov 28, 2024
Merged
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 28, 2024
@christianhaeubl christianhaeubl changed the title JFR Old Object Sampler fixes [GR-60176] JFR Old Object Sampler fixes Nov 29, 2024
@christianhaeubl
Copy link
Member

Thanks, will be integrated in the next few days.

@graalvmbot graalvmbot merged commit 83e6cf0 into oracle:master Dec 2, 2024
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@christianhaeubl christianhaeubl christianhaeubl approved these changes

Assignees

@roberttoyonaga roberttoyonaga

Labels
native-image native-image-jfr OCA Verified All contributors have signed the Oracle Contributor Agreement. redhat-interest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roberttoyonaga @christianhaeubl @graalvmbot