Remove obsolete dialect tests and update dialect list and Regenerate metadata for Hibernate 6.6.3.Final #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….6.3.Final - Removed testDeprecatedHibernateDialects() method as the tested dialects (e.g., MariaDB106Dialect, MySQL8Dialect, SQLServer2012Dialect) were removed in Hibernate 6 and the test fails. - Removed PostgresPlusDialect from provideHibernateDialects(), as it is no longer present in Hibernate 6. - Regenerated metadata
erguiti-imane
force-pushed
the
orm-hibernate-core/fix-6.6.3
branch
from
feec951 to
0853551
Compare
erguiti-imane
force-pushed
the
orm-hibernate-core/fix-6.6.3
branch
from
0853551 to
f047dc4
Compare
dnestoro
reviewed
Jul 29, 2025
| @@ -0,0 +1,4 @@ | |||
| [ | |||
There was a problem hiding this comment.
Why there is no jni-config.json when such a file was generated (and not empty): https://github.com/oracle/graalvm-reachability-metadata/pull/643/files#diff-864e9e2b44a4eb076f376cfe7f0b0f3c26557a33e847a0dd444429ab22b63558R1
| @@ -0,0 +1,15 @@ | |||
| [ | |||
There was a problem hiding this comment.
Once all necessary metadata is copied to metadata/org.hibernate.orm/hibernate-core/6.6.3.Final please remove generated-metadata directory, as we only care about what is under root level metadata directory
|
@sdeleuze can you please take a look on this PR as you were the initial author of Hibernate tests |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove obsolete dialect tests and update dialect list for Hibernate 6.6.3.Final
What does this PR do?
Code sections where the PR accesses files, network, docker or some external service
Checklist before merging