Skip to content

[Bug] Double loading symlinked files #3138

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
itarato opened this issue Jun 27, 2023 · 3 comments · May be fixed by #3189
Open

[Bug] Double loading symlinked files #3138

itarato opened this issue Jun 27, 2023 · 3 comments · May be fixed by #3189
Labels
compatibility

Comments

@itarato
Copy link
Collaborator

itarato commented Jun 27, 2023

Consider the same file loaded twice, with and without a symlinked path:

mkdir real_dir
ln -s real_dir symlink_dir
cat 'puts("Loaded")' > real_dir/script.rb
require_relative("./real_dir/script")
require_relative("./symlink_dir/script")

CRuby loads the script once (Output = Loaded\n). TruffleRuby loads it twice (Output = Loaded\nLoaded\n).

Is this a bug?
@eregon
Copy link
Member

eregon commented Jun 28, 2023

Yes, we should be compatible there.
IIRC the logic CRuby in CRuby for which part of the path to expand symlinks changed quite a bit over time, possibly we don't match what latest CRuby does there.

@rwstauner rwstauner mentioned this issue Jul 20, 2023
Merged
rwstauner added a commit to Shopify/truffleruby that referenced this issue Jul 26, 2023
@rwstauner
wip - Ensure symlinked files are not loaded twice
af7c08f 
TODO:
- changelog
- require (not relative) specs
- other specs?

closes oracle#3138
rwstauner added a commit to Shopify/truffleruby that referenced this issue Jul 27, 2023
@rwstauner
Ensure symlinked realpaths are not loaded twice
1df367c 
closes oracle#3138

Use a hash to cache realpath lookups
and another to cache realpath -> feature
similar to what was done in CRuby:
https://github.com/ruby/ruby/blob/499eb3990faeaac2603787f2a41b2d9625e180dc/load.c#L358-L402
https://github.com/ruby/ruby/blob/499eb3990faeaac2603787f2a41b2d9625e180dc/load.c#L1195-L1289
@rwstauner rwstauner linked a pull request Jul 27, 2023 that will close this issue
Open
rwstauner added a commit to Shopify/truffleruby that referenced this issue Jul 27, 2023
@rwstauner
Ensure symlinked realpaths are not loaded twice
89e47ef 
closes oracle#3138

Use a hash to cache realpath lookups
and another to cache realpath -> feature
similar to what was done in CRuby:
https://github.com/ruby/ruby/blob/499eb3990faeaac2603787f2a41b2d9625e180dc/load.c#L358-L402
https://github.com/ruby/ruby/blob/499eb3990faeaac2603787f2a41b2d9625e180dc/load.c#L1195-L1289
@eregon
Copy link
Member

eregon commented Jul 28, 2023 •
edited
Loading

Does this issue happen in practice?
It seems a change from 3.2, so I guess it would behave the same as TruffleRuby on CRuby 3.1 and before.
cc @nirvdrum

@rwstauner
Copy link
Collaborator

that was my experience, seemed to be a change in 3.2:
https://github.com/oracle/truffleruby/pull/3189/files#diff-1be38982015c7d42487f6cb0dfd50ccb664506473122a57ec378d1f34440fcd9R407

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure symlinked realpaths are not loaded twice Shopify/truffleruby
3 participants
@itarato @rwstauner @eregon