This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Issue 9 Fix #16
Merged
Issue 9 Fix #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefano De Angelis <stefano.de.angelis@oracle.com>
|
Stefano, I'm going to Slack you the requirements to add your GitHub account to the @oracle organization so that we can accept the contribution. |
rjeberhard
approved these changes
Jan 20, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 9 #9
System will first check for system property, if not present it will check ENV variable, if not present it will default it.
Documentation talk only about global variable and not system property, I kept property read to keep retro compatibility.
Fixed also a type on README.md about the variable name.
Signed-off-by: Stefano De Angelis stefano.de.angelis@oracle.com