Drop support for PHP 7.0 and PHPUnit 6 #43
Conversation
| ->in(__DIR__) | ||
| ; | ||
|
|
||
| $config = new PhpCsFixer\Config(); |
There was a problem hiding this comment.
Not a big deal neither but in my experience introducing a CS fixer has always been quite noisy, might be worth extracting it to a different PR?
There was a problem hiding this comment.
it's still small enough, so I'll leave it. I'll keep it in mind for the next time. I only added it, so we actually start using some PHP 7.1 features
composer.json
Outdated
| "php": "^7.0 || ^8.0", | ||
| "phpunit/phpunit": "^6.0 || ^7.0 || ^8.0 || ^9.0", | ||
| "symfony/console": "^2.7 || ^3.0 || ^4.0 || ^5.0 || ^6.0" | ||
| "php": ">=7.1", |
There was a problem hiding this comment.
is there a reason to not drop even lower the versions? 7.4 is going EOL soon so you could put it as minimum and still be considered very lenient in terms of support
There was a problem hiding this comment.
I couldn't find any compatibility code necessary for PHP versions between 7.1 and 7.4. PHP 8.0 will bring the "mixed" type, so I guess we can drop more versions when PHP 8.0 is as popular as PHP 7.4 is now
As suggested by @theofidry, dropping support for PHP 7.0 and PHPUnit 6
Thanks to this, we can remove some compatibility code and use PHP 7.1 features