fix: make extra log arguments as attributes #19
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems gorm slog changed log format, making those attributes as part of the message.
I dont' think this is good idea.
For example, This is what slog-gorm v1.3.0 does(when formatted by devslog handler):
With a previous version of slog-gorm, it looks like:
![截屏2024-03-21 11 40 23](https://private-user-images.githubusercontent.com/6880156/314923122-31f633bd-f395-4c33-9d0b-35d9fb94a789.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MTM2NDcsIm5iZiI6MTczOTQxMzM0NywicGF0aCI6Ii82ODgwMTU2LzMxNDkyMzEyMi0zMWY2MzNiZC1mMzk1LTRjMzMtOWQwYi0zNWQ5ZmI5NGE3ODkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMDIyMjI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTlmYWMxYjZhMWYwNzJlMzdlZjNmYWRhZGYzOThjNGM5NmExMzMyYmU1ZGI2NDkyODViOWM4MGYyYTQ3OTllMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.xC35pGXRswfgRxdQaNKXKtbtUFeMvvo7IvPoOCV5F2M)
Definitely the second one is better.
So I make this PR to recover previous behaviour.