Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: support deletion for memory resolver #607

Merged
merged 3 commits into from
Oct 2, 2023
Merged

feat: support deletion for memory resolver #607

merged 3 commits into from
Oct 2, 2023

Conversation

wangxiaoxuan273
Copy link
Contributor

Part 2/4 of #454

Based on draft PR #582

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #607 (50caeb4) into main (2d371a0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   74.46%   74.47%           
=======================================
  Files          59       59           
  Lines        5275     5277    +2     
=======================================
+ Hits         3928     3930    +2     
  Misses        993      993           
  Partials      354      354
Files Coverage Δ
internal/resolver/memory.go 100.00% <100.00%> (ø)

@wangxiaoxuan273
feat: support deletion for memory resolver
2447c9c 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
renamed as Untag
50caeb4 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Wwwsylvia
Wwwsylvia approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TerryHowe
TerryHowe approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 6456d16 into oras-project:main Oct 2, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the resolver branch October 7, 2023 03:34
@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Oct 7, 2023
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Oct 19, 2023
Closed
shizhMSFT pushed a commit that referenced this pull request Nov 20, 2023
@wangxiaoxuan273
feat: extend oci.Store with Delete() (#614)
75d200e 
Part 4/4 of #454 

This PR should be reviewed and merged after PR #606 #607 #608

---------

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Nov 21, 2023
Closed
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
Closed
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangxiaoxuan273 @codecov-commenter @TerryHowe @Wwwsylvia @shizhMSFT