perf: reduce auth request count for manifest delete #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Wwwsylvia
requested review from
sajayantony,
shizhMSFT and
SteveLasker
as code owners
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #618 +/- ##
=======================================
Coverage 75.11% 75.11%
=======================================
Files 59 59
Lines 5420 5421 +1
=======================================
+ Hits 4071 4072 +1
Misses 994 994
Partials 355 355
|
shizhMSFT
reviewed
Oct 17, 2023
Wwwsylvia
changed the title
Wwwsylvia
added a commit
to Wwwsylvia/oras-go
that referenced
this pull request
Oct 20, 2023
Add `pull` and `delete` scope hints before attempting client-side indexing on manifest delete. Resolve: oras-project#594 Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Wwwsylvia
added a commit
that referenced
this pull request
Oct 20, 2023
Backporting 0f1dc30 to the release branch. This change does the same thing as the original commit (#618) did but using the old `registryutil.WithScopeHint` instead of `auth.AppendRepositoryScope`, which is introduced by #604 and is not available in `v2.3.x`. Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pullanddeletescope hints before attempting client-side indexing on manifest delete.Resolve: #594
Before this change, the requests produced during deleting a manifest when Referrers API is not known to be available:
#0: GET manifest - 401#1: POST token (scope: pull) - 200#2: GET manifest - 200#3: GET referrers index - 200#4: PUT referrers index - 401#5: POST token (scope: pull, push) - 200#6: PUT referrers index - 201#7: DELETE manifest - 401#8: POST token (scope: delete)#9: DELETE manifest - 202After this change, the requests should become:
#0: GET manifest - 401#1: POST token (scope: pull, delete) - 200#2: GET manifest - 200#3: GET referrers index - 200#4: PUT referrers index - 401#5: POST token (scope: pull, push) - 200#6: PUT referrers index - 201#7: DELETE manifest - 202