Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modify workflow grid #751

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Modify workflow grid #751

merged 2 commits into from
Jul 11, 2022

Conversation

j3r3m1
Copy link
Collaborator

@j3r3m1 j3r3m1 commented Jul 8, 2022

There was two mistakes in the workflow:

  • troubles to calculate sea/land fractions in the rasterize function
  • values written in the ascii grid were null instead of -9999

j3r3m1
j3r3m1 commented Jul 8, 2022
View reviewed changes
...ndicators/src/main/groovy/org/orbisgis/geoclimate/geoindicators/WorkflowGeoIndicators.groovy
AS SELECT explod_id, the_geom, $seaLandTypeField
FROM ST_EXPLODE('(SELECT st_tessellate(the_geom) AS the_geom, $seaLandTypeField
FROM $seaLandMaskTableName
WHERE ST_DIMENSION(the_geom) = 2 AND ST_ISEMPTY(the_geom) IS NOT TRUE
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can directly do that when the sea_land_mask is created ?

ebocher
ebocher approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@ebocher ebocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceptionnel, brillant !

@ebocher ebocher merged commit 5a89d93 into orbisgis:master Jul 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ebocher ebocher ebocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j3r3m1 @ebocher