Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(flake): fix test failure on Nix #30

Merged
merged 1 commit into from
Sep 15, 2024
Merged

fix(flake): fix test failure on Nix #30

merged 1 commit into from
Sep 15, 2024

Conversation

ch4og
Copy link
Contributor

@ch4og ch4og commented Sep 14, 2024

Closes #27

Please check my comment on issue for more info

@ch4og ch4og requested a review from orhun as a code owner September 14, 2024 16:05
@ch4og ch4og changed the title Fix test failure on NixOS Fix test failure on Nix Sep 14, 2024
@ch4og ch4og changed the title Fix test failure on Nix fix(flake): fix test failure on Nix Sep 14, 2024
@Qubasa
Copy link

Qubasa commented Sep 14, 2024

+1

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orhun orhun merged commit fa152e8 into orhun:main Sep 15, 2024
12 of 13 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.67%. Comparing base (d9e71a0) to head (9579a33).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #30   +/-   ##
=====================================
  Coverage   3.67%   3.67%           
=====================================
  Files         18      18           
  Lines       2212    2212           
=====================================
  Hits          81      81           
  Misses      2131    2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nix test failure (test_extract_strings)
4 participants