Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(cli): add --tab argument #60

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

josueBarretogit
Copy link
Contributor

@josueBarretogit josueBarretogit commented Oct 1, 2024

Description of change

This feature lets user launch binsider from a different tab other than general
closes #6

How has this been tested? (if applicable)

running binsider should start at general tab, the default value
if you run

binsider --tab hexdump

binsider should be running at hexdump tab

also if you mistype you get this message

❯ binsider --tab hex
error: invalid value 'hex' for '--tab <TAB>'
  [possible values: general, static-analysis, dynamic-analysis, strings, hexdump]

  tip: a similar value exists: 'hexdump'

For more information, try '--help'.

This feature lets user launch binsider from a different tab other than general
@josueBarretogit josueBarretogit requested a review from orhun as a code owner October 1, 2024 16:17
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! <3

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 3.34%. Comparing base (ad7cca3) to head (24a80af).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tui/state.rs 0.00% 3 Missing ⚠️
src/lib.rs 0.00% 2 Missing ⚠️
src/args.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #60      +/-   ##
========================================
- Coverage   3.35%   3.34%   -0.00%     
========================================
  Files         19      19              
  Lines       2392    2399       +7     
========================================
  Hits          80      80              
- Misses      2312    2319       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit aba6112 into orhun:main Oct 1, 2024
26 of 27 checks passed
@orhun orhun changed the title feat(Cli): add argument --tab feat(cli): add --tab argument Oct 1, 2024
@josueBarretogit josueBarretogit deleted the start_at_different_tab_from_cli branch October 1, 2024 18:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch TUI from selected tab
2 participants