Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): bump libc from 0.2.146 to 0.2.155 #170

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

znley
Copy link
Contributor

@znley znley commented Jun 3, 2024

Description

Motivation and Context

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@znley znley requested a review from orhun as a code owner June 3, 2024 07:36
@orhun
Copy link
Owner

orhun commented Jun 3, 2024

I'd rather have this more explicit by updating the versions in Cargo.toml as well. Did you just run cargo update?

@znley
Copy link
Contributor Author

znley commented Jun 4, 2024

@orhun Yes, I just run cargo update to upgrade Cargo.lock. My main purpose is upgrade libc to 0.2.155 to build and run systeroid on loongarch64-alpine-linux-musl.

@orhun
Copy link
Owner

orhun commented Jun 4, 2024

I see, then can you make the necessary changes in Cargo.toml (e.g. env_logger) or make this PR only scoped to update libc?

libc crate support loongarch64-alpine-linux-musl since 0.2.155
@znley znley changed the title chore(deps): upgrade all packages versions chore(deps): bump libc from 0.2.146 to 0.2.155 Jun 4, 2024
@znley
Copy link
Contributor Author

znley commented Jun 4, 2024

@orhun Ok, I upgrade libc only, I think edit Cargo.lock is enough.

@orhun orhun merged commit 4e60549 into orhun:main Jun 4, 2024
11 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants